Skip to content

feature: list-of-types #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
reuvenharrison merged 8 commits into from
Aug 7, 2025
Merged

feature: list-of-types #736

reuvenharrison merged 8 commits into from
Aug 7, 2025

Conversation

@reuvenharrison
Copy link
Collaborator

@reuvenharrison reuvenharrison commented Aug 5, 2025

This PR handles an OpenAPI design pattern: "using oneOf/anyOf to allow multiple types"
This PR addresses: #722 and #723

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 89.62818% with 53 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@9c181be). Learn more about missing BASE report.

Files with missing lines Patch % Lines
checker/list_of_types_core.go 94.28% 7 Missing and 3 partials ⚠️
diff/list_of_types_diff.go 92.48% 7 Missing and 3 partials ⚠️
checker/check_request_property_any_of_updated.go 0.00% 3 Missing and 2 partials ⚠️
...er/check_request_property_list_of_types_changed.go 90.90% 3 Missing and 2 partials ⚠️
checker/check_request_property_one_of_updated.go 0.00% 3 Missing and 2 partials ⚠️
checker/check_request_property_type_changed.go 16.66% 3 Missing and 2 partials ⚠️
...r/check_response_property_list_of_types_changed.go 90.74% 3 Missing and 2 partials ⚠️
...r/check_request_parameter_list_of_types_changed.go 95.65% 1 Missing and 1 partial ⚠️
checker/check_response_property_any_of_updated.go 60.00% 1 Missing and 1 partial ⚠️
checker/check_response_property_one_of_updated.go 60.00% 1 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #736   +/-   ##
=======================================
  Coverage        ?   87.85%           
=======================================
  Files           ?      246           
  Lines           ?    14555           
  Branches        ?        0           
=======================================
  Hits            ?    12787           
  Misses          ?     1332           
  Partials        ?      436
Flag Coverage Δ
unittests 87.85% <89.62%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reuvenharrison reuvenharrison merged commit a124dc7 into main Aug 7, 2025
14 checks passed
@reuvenharrison reuvenharrison deleted the list-of-types branch August 7, 2025 06:59
This was referenced Aug 7, 2025
Closed
Closed
@nesk
Copy link

nesk commented Aug 10, 2025

Thank you for your work on the related issues! I'm not currently able to try the new release yet (I'm in vacations) but I'm happy to see you found time to fix them. I'll try once I'm back :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@reuvenharrison @codecov-commenter @nesk