Skip to content

Conversation

@reuvenharrison
Copy link
Collaborator

@reuvenharrison reuvenharrison commented Jul 6, 2025

Fix #712 by using a pointer to components rather than embedding it in diff.

@reuvenharrison reuvenharrison linked an issue Jul 6, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2025

Codecov Report

Attention: Patch coverage is 97.72727% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.60%. Comparing base (685f943) to head (78aa145).

Files with missing lines Patch % Lines
diff/components_diff.go 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #725      +/-   ##
==========================================
+ Coverage   87.58%   87.60%   +0.01%     
==========================================
  Files         241      241              
  Lines       13956    13971      +15     
==========================================
+ Hits        12224    12239      +15     
  Misses       1311     1311              
  Partials      421      421              
Flag Coverage Δ
unittests 87.60% <97.72%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reuvenharrison reuvenharrison merged commit 31d6323 into main Jul 6, 2025
14 checks passed
@reuvenharrison reuvenharrison deleted the 712-yaml-and-json-diffs-differ branch July 6, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

yaml and json diffs differ

3 participants