fix isJsonMediaType (#688)

reuvenharrison · web-flow · commit 40cdeb5ac67e · 2025-04-12T13:16:28.000+03:00
diff --git a/checker/check_types.go b/checker/check_types.go
@@ -107,8 +107,8 @@ func isStronglyTyped(mediaType string) bool {
 }
 
 func isJsonMediaType(mediaType string) bool {
-	return mediaType == "application/json" ||
-		(strings.HasPrefix(mediaType, "application/vnd.") && strings.HasSuffix(mediaType, "+json"))
+	// Structured Syntax Suffixes: https://www.rfc-editor.org/rfc/rfc6838#section-4.2.8
+	return mediaType == "application/json" || strings.HasSuffix(mediaType, "+json")
 }
 
 // isFormatContained checks if from is contained in to
diff --git a/checker/check_types_test.go b/checker/check_types_test.go
@@ -132,3 +132,14 @@ func TestFormatAdded(t *testing.T) {
 	}
 	breaking(t, typeDiff, formatDiff, false, revisionType)
 }
+
+func TestIsJsonMediaType(t *testing.T) {
+	require.True(t, isJsonMediaType("application/json"))
+	require.True(t, isJsonMediaType("application/problem+json"))
+	require.True(t, isJsonMediaType("application/vnd.api+json"))
+	require.True(t, isJsonMediaType("application/any-string+json"))
+	require.False(t, isJsonMediaType("application/xml"))
+	require.False(t, isJsonMediaType("text/plain"))
+	require.False(t, isJsonMediaType("application/json-patch")) // Note: Differs from application/json-patch+json
+	require.False(t, isJsonMediaType(""))
+}

Original file line number	Diff line number	Diff line change
`@@ -107,8 +107,8 @@ func isStronglyTyped(mediaType string) bool {`
`107`	`107`	`}`
`108`	`108`
`109`	`109`	`func isJsonMediaType(mediaType string) bool {`
`110`		`- return mediaType == "application/json" \|\|`
`111`		`- (strings.HasPrefix(mediaType, "application/vnd.") && strings.HasSuffix(mediaType, "+json"))`
	`110`	`+ // Structured Syntax Suffixes: https://www.rfc-editor.org/rfc/rfc6838#section-4.2.8`
	`111`	`+ return mediaType == "application/json" \|\| strings.HasSuffix(mediaType, "+json")`
`112`	`112`	`}`
`113`	`113`
`114`	`114`	`// isFormatContained checks if from is contained in to`