Skip to content

feat: support multiple app deploys in a single PR#484

Merged
nwtgck merged 1 commit intonwtgck:developfrom
kaisermann:feature/support-multiple-deploy-messages
Apr 26, 2021
Merged

feat: support multiple app deploys in a single PR#484
nwtgck merged 1 commit intonwtgck:developfrom
kaisermann:feature/support-multiple-deploy-messages

Conversation

@kaisermann
Copy link
Copy Markdown
Contributor

Adds the Netlify app id to the comment identifier message.

Closes #384

@kaisermann kaisermann force-pushed the feature/support-multiple-deploy-messages branch 2 times, most recently from 1be48eb to 87bd0ee Compare March 25, 2021 19:56
@kaisermann kaisermann force-pushed the feature/support-multiple-deploy-messages branch from 87bd0ee to c05bc27 Compare March 25, 2021 19:56
@acao
Copy link
Copy Markdown

acao commented Apr 18, 2021

Have the same issue where the PR comments overwrite each other.

@nwtgck
Copy link
Copy Markdown
Owner

nwtgck commented Apr 26, 2021

Thanks all.

I made a modification. Site ID may be safe to leak on the comment, but this action suggests site id is in the GitHub secret. So, site ID is now embedded as SHA256 for security.

image
test: #515

@nwtgck nwtgck merged commit a01ea2e into nwtgck:develop Apr 26, 2021
@kaisermann kaisermann deleted the feature/support-multiple-deploy-messages branch April 27, 2021 00:05
@nwtgck
Copy link
Copy Markdown
Owner

nwtgck commented Apr 29, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for multiple deploys on the same PR?

3 participants