Skip to content

DNN button styled to match Bootstrap buttons#344

Merged
david-poindexter merged 2 commits into
nvisionative:developfrom
dnndiva:DNNbuttons
Dec 12, 2022
Merged

DNN button styled to match Bootstrap buttons#344
david-poindexter merged 2 commits into
nvisionative:developfrom
dnndiva:DNNbuttons

Conversation

@dnndiva

@dnndiva dnndiva commented Dec 9, 2022

Copy link
Copy Markdown
Contributor

Related to Issue

Fixes #343

Description

Added styling to DNN buttons to look like the theme bootstrap buttons

How Has This Been Tested?

Added button with the 3 DNN system button classes on my local development environment.

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@david-poindexter david-poindexter added the enhancement New feature or request label Dec 12, 2022
@david-poindexter david-poindexter added this to the 3.1.0 milestone Dec 12, 2022

@david-poindexter david-poindexter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dnndiva - just a few minor cleanup items.

Comment thread src/scss/components/_dnn.scss Outdated
.dnnTertiaryAction {
padding: 6px 6px;
}
.dnnTertiaryAction {}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be removed if there are no associated styles to define.

Comment thread src/scss/components/_dnn.scss Outdated
/* Old browsers */
color: #fff;
}
a.dnnPrimaryAction:hover {}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be removed if there are no associated styles to define.

Comment thread src/scss/components/_dnn.scss Outdated
background: color('dnnPrimaryAction');
color: #fff;
}
a.dnnPrimaryAction:active {}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be removed if there are no associated styles to define.

Comment thread src/scss/components/_dnn.scss Outdated
/* Old browsers */
color: #555;
}
.dnnLogin .LoginTabGroup span:hover {}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be removed if there are no associated styles to define.

Comment thread src/scss/components/_dnn.scss Outdated
a.dnnTertiaryAction:hover {
background: #f2f2f2;
}
a.dnnTertiaryAction:hover {}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be removed if there are no associated styles to define.

Comment thread src/scss/components/_dnn.scss Outdated
a.dnnTertiaryAction:active {
background: color('dnnTertiaryAction');
}
a.dnnTertiaryAction:active {}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be removed if there are no associated styles to define.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@david-poindexter david-poindexter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👏

@david-poindexter
david-poindexter merged commit 2e75dde into nvisionative:develop Dec 12, 2022
@dnndiva
dnndiva deleted the DNNbuttons branch December 12, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Style DNN system buttons to look like the theme buttons would be nice

2 participants