Skip to content

Added italic counterparts of theme fonts#332

Merged
david-poindexter merged 1 commit into
nvisionative:developfrom
dnndiva:italic-fonts
Nov 11, 2022
Merged

Added italic counterparts of theme fonts#332
david-poindexter merged 1 commit into
nvisionative:developfrom
dnndiva:italic-fonts

Conversation

@dnndiva

@dnndiva dnndiva commented Nov 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Added italic versions of Open Sans Fonts

Description

resolves #333

  • added italic version of the font files
  • listed fonts on partials/_includes.ascx file
  • added CSS references src/scss/variables/_fonts.scss

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@sonarqubecloud

sonarqubecloud Bot commented Nov 11, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dnndiva dnndiva changed the title added italic fonts Added italic counterparts of theme fonts Nov 11, 2022
david-poindexter
david-poindexter requested changes Nov 11, 2022
View reviewed changes

@david-poindexter david-poindexter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dnndiva you included SemiBold in _includes.ascx but the woff and woff2 files for that variation are missing. The @font-face definition has also been missed for SemiBold.

@david-poindexter david-poindexter added the enhancement New feature or request label Nov 11, 2022
@david-poindexter david-poindexter added this to the 3.0.0 milestone Nov 11, 2022
@dnndiva

dnndiva commented Nov 11, 2022

Copy link
Copy Markdown
Contributor Author

@david-poindexter, the SemiBold font and reference were already on the theme. I just added the italic version of the fonts. Just did a recheck and this is correct. Am I missing something?

@david-poindexter

david-poindexter commented Nov 11, 2022

Copy link
Copy Markdown
Member

@david-poindexter, the SemiBold font and reference were already on the theme. I just added the italic version of the fonts. Just did a recheck and this is correct. Am I missing something?

Okay, I see what happened now. The file diff was a bit misleading. You are right though - the SemiBold was already there. Thanks!

@david-poindexter
david-poindexter merged commit bb60267 into nvisionative:develop Nov 11, 2022
@dnndiva
dnndiva deleted the italic-fonts branch November 11, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@david-poindexter david-poindexter david-poindexter approved these changes

Assignees

@dnndiva dnndiva

Labels

enhancement New feature or request

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

Missing italic counterparts of fonts currently on the theme

2 participants

@dnndiva @david-poindexter