Update to Bootstrap 5#311
Merged
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
david-poindexter
approved these changes
Oct 23, 2022
david-poindexter
left a comment
david-poindexter
left a comment
Member
There was a problem hiding this comment.
Very nice @tksheppard - thank you! 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to Issue
Fixes #312
Description
This update increases the version of Bootstrap up to 5.2.2 which is a major version update. Luckily this didn't include many changes to the base theme itself, though people using nvQuickTheme will need to update their Bootstrap usage accordingly.
How Has This Been Tested?
Updated the Bootstrap dependency using yarn upgrade. Checked package.json and yarn.lock to make sure upgrade was clean. Updated all Bootstrap usage in theme. Removed deprecation suppression. Ran gulp build without any warnings or errors. Checked default theme in DNN to make sure no warnings or errors.
Screenshots (if appropriate):
Types of changes
Checklist:
Note: I'm not sure if this will count as a breaking change. It doesn't break any nvQuickTheme functionality, but it may impact outside usage of the theme resources (modules, structured content, etc).