Skip to content

Replace slimmenu#303

Merged
david-poindexter merged 5 commits into
nvisionative:developfrom
tksheppard:replace-slimmenu
Oct 15, 2022
Merged

Replace slimmenu#303
david-poindexter merged 5 commits into
nvisionative:developfrom
tksheppard:replace-slimmenu

Conversation

@tksheppard

@tksheppard tksheppard commented Oct 6, 2022

Copy link
Copy Markdown
Collaborator

Related to Issue

Fixes #310

Description

Replaces slimmenu with a much leaner, cleaner, and more modern solution.

How Has This Been Tested?

Updated and tested in a local environment

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@tksheppard

Copy link
Copy Markdown
Collaborator Author

I will note that the Sonar Code analysis is failing because it doesn't like the DDR menu template. The <li> elements aren't seen as being correctly included in a <ul>. Thus failing the analysis.

@david-poindexter

Copy link
Copy Markdown
Member

Thanks @tksheppard - I'll review this one soon.

@sonarqubecloud

sonarqubecloud Bot commented Oct 15, 2022

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
10.1% 10.1% Duplication

@david-poindexter david-poindexter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @tksheppard - thank you! 🌮

@david-poindexter
david-poindexter merged commit e884ac3 into nvisionative:develop Oct 15, 2022
@david-poindexter david-poindexter added this to the 2.4.0 milestone Oct 15, 2022
@david-poindexter david-poindexter modified the milestones: 2.4.0, 3.0.0 Oct 23, 2022
@tksheppard
tksheppard deleted the replace-slimmenu branch February 16, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace slimmenu with one that does not depend on jQuery

2 participants