Implement contemporary dnn Buttons with color names#290
Conversation
|
It would be nice if the active colors could be calculated automatically from the non-active background colors. I do not know enough about the mixins functions in the nvQT to handle that. |
EPTamminga
changed the title
david-poindexter
left a comment
david-poindexter
left a comment
There was a problem hiding this comment.
@EPTamminga thank you for the PR! There are some great enhancements here that many will find useful. 🎉
Also, it dawned on me during this review that we have some issues with the actual color palette here and it does not match the color palette currently used on https://nvquicktheme.com. We will work to resolve this prior to the next release.
Remove comment, as this is not the only this is, or can be used.
Remove comment, as this is not the only this is, or can be used.
Remove comment, as this is not the only this is, or can be used.
|
Kudos, SonarCloud Quality Gate passed!
|
2 participants
Related to Issue
Fixes #288 #286
Description
Added a few color names, added explanation for other color names
Changed the _dnn button definitions to create flat contemporary-looking buttons
How Has This Been Tested?
Used a HTML text module with all different kinds of HTML elements
Screenshots (if appropriate):
Types of changes
Colors, DNN button scss
Checklist: