Skip to content

Fix layouts using bootstrap#264

Merged
david-poindexter merged 8 commits into
nvisionative:developfrom
tksheppard:fix_layouts-using-bootstrap
Jun 18, 2021
Merged

Fix layouts using bootstrap#264
david-poindexter merged 8 commits into
nvisionative:developfrom
tksheppard:fix_layouts-using-bootstrap

Conversation

@tksheppard

@tksheppard tksheppard commented Jun 18, 2021

Copy link
Copy Markdown
Collaborator

Related to Issue

Fixes #

Description

  • Trimmed down excess Panes in default.ascx to provide a cleaner starting point.
  • Contained ContentPane so auto-generated DNN pages will be contained by default.
  • Adapted header.ascx and footer.ascx to correctly using boostrap DOM structure.
  • Cleaned SCSS related to header and footer lists.
  • Changed name of .nav-main to .navbar-header to be clearer.

How Has This Been Tested?

Ran gulp build and it compiled correctly. Checked output theme in DNN instance. It showed to be fully functional.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@tksheppard
tksheppard force-pushed the fix_layouts-using-bootstrap branch from 24274d2 to 05a6f29 Compare June 18, 2021 21:34
@sonarqubecloud

sonarqubecloud Bot commented Jun 18, 2021

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@david-poindexter david-poindexter added the enhancement New feature or request label Jun 18, 2021
@david-poindexter david-poindexter added this to the 2.3.0 milestone Jun 18, 2021
@david-poindexter
david-poindexter self-requested a review June 18, 2021 22:01
david-poindexter
david-poindexter approved these changes Jun 18, 2021
View reviewed changes

@david-poindexter david-poindexter left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tksheppard - this will most likely break nvquicktheme.com content, but we can address that on-site. I see these changes as marked improvements and believe it is a much cleaner base starting point. Awesome work! 🎉

@david-poindexter
david-poindexter merged commit 1516b13 into nvisionative:develop Jun 18, 2021
@tksheppard
tksheppard deleted the fix_layouts-using-bootstrap branch June 24, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@david-poindexter david-poindexter david-poindexter approved these changes

Assignees

@tksheppard tksheppard

Labels

enhancement New feature or request

Projects

None yet

Milestone

2.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@tksheppard @david-poindexter