Skip to content

Strange Text Alignment issue in BannerPane, ContentPane, and SinglePaneOne #222

Description

@skrantzman

Please summarize your question in one sentence

What is the benefit of the "text-center" class in the ContentPane vs just using the alignment features in the built-in html editor, and where is text-center defined?

Give a more extended description

If you place a Html module in the ContentPane (as well as BannerPane and SinglePaneOne), strange alignment behavior arises when trying to align text. Using the built-in html editor's alignment feature, you can center align, justify, and right align text. If you change the alignment in the editor to left align, the result is center aligned text. Removing the text-center class from these panes does allow you to align text anyway you want to, via the htlm editor, including left aligned.

My first thought is why would you define the text alignment in the ascx file, as this prevents the average Page Editor from controling alignment as they see fit, My second thought was that you must have had a good reason by doing just that. If you set text alignment in the html editor to left align, and then inspect the text, you will see that text-align: left is being overridden by "center !important" from the text-center class in the _breakpoints.scss file on line 61. Yet there is nothing in the file that has anything to do with text-align or text-center. I searched the entire project but am unable to find out where the text-center class is defined.

So my questions are:

  • Where is the text-center class defined?
  • What is the purpose of this class (why use it instead of the html editor's text align feature?)
  • When using the html editor's align feature why is align left the only alignment overridden by the text-center class?

Steps to reproduce (if needed)

  1. Clean install of nvQuicktheme 2.1, or 2.2 or possibly 2.0
  2. Compile, build and view theme in browser
  3. Add html module to ContentPane and add text.
  4. Change alignment of text using the built-in html editor to left aligned.
  5. View results on page - text is still center aligned.

Other comments or remarks

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionFurther information is requested

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions