Skip to content

doc: Add translation for Simplified Chinese(zh-CN)#19

Merged
nvh95 merged 14 commits intonvh95:mainfrom
rivertwilight:main
Jan 8, 2023
Merged

doc: Add translation for Simplified Chinese(zh-CN)#19
nvh95 merged 14 commits intonvh95:mainfrom
rivertwilight:main

Conversation

@rivertwilight
Copy link
Copy Markdown
Contributor

@rivertwilight rivertwilight commented Jan 5, 2023

Summary/ Motivation (TLDR;)

Translation for zh-CN.

Use the dropdown menu on the top to switch languages.

image

As I didn't find how to customize the navbar for each page, the navbar items have not to be translated.

@netlify
Copy link
Copy Markdown

netlify bot commented Jan 5, 2023

Deploy Preview for vitest-preview ready!

Name Link
🔨 Latest commit 5d51f72
🔍 Latest deploy log https://app.netlify.com/sites/vitest-preview/deploys/63b6d9d650460e0008aaf37b
😎 Deploy Preview https://deploy-preview-19--vitest-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rivertwilight rivertwilight marked this pull request as ready for review January 5, 2023 12:59
Copy link
Copy Markdown

@jsun969 jsun969 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is /.vitepress/cache/deps a runtime folder? I assume it should be removed.

@jsun969
Copy link
Copy Markdown

jsun969 commented Jan 5, 2023

Use pnpm instead of yarn

# Svelte Testing Library

See more at <https://github.com/nvh95/vitest-preview/tree/main/examples/svelte-testing-library>
参见 <https://github.com/nvh95/vitest-preview/tree/main/examples/svelte-testing-library>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the origin doc

@rivertwilight
Copy link
Copy Markdown
Contributor Author

All addressed. Thanks! @jsun969

Copy link
Copy Markdown
Owner

@nvh95 nvh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nvh95 nvh95 merged commit 04ebc6e into nvh95:main Jan 8, 2023
@nvh95
Copy link
Copy Markdown
Owner

nvh95 commented Jan 8, 2023

@rivertwilight Thank you very much for your time invested in vitest-preview 🥰
@jsun969 Thanks for your help in reviewing this PR.

@nvh95
Copy link
Copy Markdown
Owner

nvh95 commented Jan 8, 2023

@all-contributors please add @rivertwilight for translation

@allcontributors
Copy link
Copy Markdown
Contributor

@nvh95

I've put up a pull request to add @rivertwilight! 🎉

@nvh95
Copy link
Copy Markdown
Owner

nvh95 commented Apr 24, 2023

Hi @rivertwilight @jsun969. I just found out that the merge commit hasn't been deployed to production. I just cleared cache and manually deploy the Chinese version of the docs. You can check it out at https://www.vitest-preview.com/zh/

Again. Thank you for your help 🎉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants