Python3 compatible version of txt2tags#12
Merged
Conversation
LeonarddeR
requested changes
Jun 1, 2019
LeonarddeR
left a comment
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
Are you sure you used the right base version of txt2tags/ There seem to be some lines with unnecessary/unexpected changes in this.
LeonarddeR
requested changes
Jun 4, 2019
LeonarddeR
left a comment
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
Wow, this work must have been huge.
nishimotz
added a commit
to nvdajp/txt2tags
that referenced
this pull request
Jun 4, 2019
Contributor
Author
|
resolved some conversations which are addressed and confirmed with the test environment of the nvdajp repository. |
LeonarddeR
reviewed
Jun 4, 2019
nishimotz
added a commit
to nvdajp/txt2tags
that referenced
this pull request
Jun 4, 2019
Collaborator
|
Do you need any clarification for the open conversations? |
Contributor
Author
|
I will address remaining things later. |
nishimotz
added a commit
to nvdajp/txt2tags
that referenced
this pull request
Jun 4, 2019
nishimotz
added a commit
to nvdajp/txt2tags
that referenced
this pull request
Jun 4, 2019
nishimotz
added a commit
to nvdajp/txt2tags
that referenced
this pull request
Jun 4, 2019
nishimotz
added a commit
to nvdajp/txt2tags
that referenced
this pull request
Jun 5, 2019
nishimotz
added a commit
to nvdajp/txt2tags
that referenced
this pull request
Jun 5, 2019
nishimotz
added a commit
to nvdajp/txt2tags
that referenced
this pull request
Jun 5, 2019
LeonarddeR
reviewed
Jun 5, 2019
LeonarddeR
left a comment
LeonarddeR
left a comment
Collaborator
There was a problem hiding this comment.
I agree with writing in binary mode, that makes sense.
nishimotz
added a commit
to nvdajp/txt2tags
that referenced
this pull request
Jun 5, 2019
LeonarddeR
requested changes
Jun 8, 2019
Co-Authored-By: Leonard de Ruijter <[email protected]>
Co-Authored-By: Leonard de Ruijter <[email protected]>
Co-Authored-By: Leonard de Ruijter <[email protected]>
nishimotz
added a commit
to nvdajp/txt2tags
that referenced
this pull request
Jun 9, 2019
LeonarddeR
approved these changes
Jun 10, 2019
michaelDCurran
approved these changes
Jun 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: nvaccess/nvda#8734
Related PR: nvaccess/nvda#9648
It replaces txt2tags.py with my work of https://github.com/nvdajp/txt2tags.