V2 of disable caret events in the UIA console#9986
Merged
feerrenrut merged 2 commits intonvaccess:masterfrom Jul 31, 2019
Merged
V2 of disable caret events in the UIA console#9986feerrenrut merged 2 commits intonvaccess:masterfrom
feerrenrut merged 2 commits intonvaccess:masterfrom
Conversation
Contributor
Author
Collaborator
|
Are you sure disabling events here doesn't cause other side effects that were fixed earlier? |
Contributor
Author
Caret movement seems functional after the change. Are there specific cases I should test? |
Collaborator
|
Caret movement seems functional after the change. Are there specific
cases I should test?
I can't think of any. Might be good to check whether backspacing reports
changes for all the versions of windows 10 you're trying to support.
|
LeonarddeR
approved these changes
Jul 29, 2019
Contributor
Author
|
@feerrenrut @LeonarddeR Works as expected on Windows 10 1803 and 1903. |
feerrenrut
pushed a commit
that referenced
this pull request
Aug 22, 2019
In Mintty, the last character of the prompt was being read when quickly deleting text, just as in Windows Console (see this comment and the "summary of the issue" section in #9986). This change disables caret events for all Terminal objects by overriding NVDAObjects.behaviors.Terminal._get_caretMovementDetectionUsesEvents, instead of only Windows Console like in #9986. Closes #1348. Related to #9933, #9986.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Builds on #9614. Identical to #9985.
Summary of the issue:
Steps to reproduce:
cmd.exe).Expected behavior: NVDA reads the characters being deleted, then nothing once none are left.
Observed behavior: NVDA sometimes reads the last character of the prompt when deleting fast enough.
Description of how this pull request fixes the issue:
This PR disables the caret movement event detection from #9933 for UIA consoles (as with IA2 web).
Testing performed:
Tested above steps and verified that the issue is no longer reproducible.
Known issues with pull request:
Caret events may be useful in consoles, so we may want to look for a better workaround at some stage. This PR at least restores behavior from before py3.
Change log entry:
None.