UI Automation in Windows Console: fix "review start of line" script#9944
Merged
feerrenrut merged 1 commit intonvaccess:masterfrom Jul 31, 2019
Merged
UI Automation in Windows Console: fix "review start of line" script#9944feerrenrut merged 1 commit intonvaccess:masterfrom
feerrenrut merged 1 commit intonvaccess:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
codeofdusk
force-pushed
the
cmduia8-firstchar
branch
from
f070359 to
a77ba10
Compare
Contributor
|
When is the _expandCollapseBeforeReview flag typically set / not set. Why is it the case? |
Contributor
Author
The |
feerrenrut
approved these changes
Jul 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None.
Summary of the issue:
Currently, in UIA consoles, invoking the "review start of line" script (shift+numpad 1 by default) does not move the review cursor.
Description of how this pull request fixes the issue:
Since expanding and collapsing the
textInfois essential for the functionality of this script (to move thetextInfoto the start of the line), we should ignore the_expandCollapseBeforeReviewflag.Testing performed:
Tested that the script works as expected in UIA consoles on Windows 10 1903. Legacy consoles are unaffected (as they remain functional).
Known issues with pull request:
None.
Change log entry:
None.