Update brlapi to 0.8.7 for python 3.13#19018
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the BRLTTY brlapi module to version 0.8.7 to support Python 3.13 compatibility. The primary change addresses broken BRLTTY functionality that occurred when NVDA transitioned to Python 3.13.
- Updates miscDeps submodule to include the new BRLTTY build
- Re-enables unit tests for BRLTTY that were previously skipped
- Updates documentation to reflect the version bump
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| user_docs/en/changes.md | Adds changelog entry documenting the BRLTTY update to version 0.8.7 |
| tests/unit/test_braille/test_brailleDisplayDrivers.py | Removes version and platform restrictions to re-enable BRLTTY unit tests |
| projectDocs/dev/createDevEnvironment.md | Updates development documentation to reflect new BRLTTY version requirement |
| miscDeps | Updates submodule commit to include the new BRLTTY build |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
seanbudd
commented
Oct 3, 2025
SaschaCowley
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #18657
Merges changes from nvaccess/brltty#1 and nvaccess/nvda-misc-deps#39
Summary of the issue:
BRLTTY needs to be updated for 64bit and python 3.13.
Since updating python it has been broken on alphas.
Description of user facing changes:
BRLTTY restored usage restored
Description of developer facing changes:
None
Description of development approach:
Update commit from miscDeps built from https://github.com/nvaccess/brltty/pull/
Testing strategy:
Unit tests re-enabled
Known issues with pull request:
None
Code Review Checklist: