Skip to content

Remove unneeded and unused TermControl2 class name#17269

Merged
SaschaCowley merged 1 commit intonvaccess:masterfrom
codeofdusk:rm-termcontrol2
Oct 9, 2024
Merged

Remove unneeded and unused TermControl2 class name#17269
SaschaCowley merged 1 commit intonvaccess:masterfrom
codeofdusk:rm-termcontrol2

Conversation

@codeofdusk
Copy link
Contributor

Link to issue number:

microsoft/terminal#12358

Summary of the issue:

For microsoft/terminal#12358, we discussed having a second TermControl2 class name to distinguish terminals that do and don't support UIA notifications, but this was never implemented and there are no plans to do so.

Description of how this pull request fixes the issue:

Remove unneeded constant

Testing strategy:

Alpha testing

Known issues with pull request:

None known

Change log entry:

None needed

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@codeofdusk codeofdusk requested review from a team as code owners October 9, 2024 19:30
@SaschaCowley SaschaCowley merged commit 4de8af7 into nvaccess:master Oct 9, 2024
@github-actions github-actions bot added this to the 2025.1 milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants