Merge beta to master#14111
Merged
Merged
Conversation
From translation svn revision: 69587 Authors: Bernd Dorer <[email protected]> David Parduhn <[email protected]> Rene Linke <[email protected]> Adriani Botez <[email protected]> Karl Eick <[email protected]> Robert Hänggi <[email protected]> Astrid Waldschmetterling <[email protected]> Stats: 10 2 user_docs/de/changes.t2t 1 file changed, 10 insertions(+), 2 deletions(-)
From translation svn revision: 69587 Authors: Jani Kinnunen <[email protected]> Isak Sand <[email protected]> Stats: 7 0 user_docs/fi/changes.t2t 1 file changed, 7 insertions(+)
From translation svn revision: 69587 Authors: Michel such <[email protected]> Patrick ZAJDA <[email protected]> Remy Ruiz <[email protected]> Abdelkrim Bensaid <[email protected]> Cyrille Bougot <[email protected]> Corentin Bacqué-Cazenave <[email protected]> Sylvie Duchateau <[email protected]> Sof <[email protected]> Stats: 25 9 source/locale/fr/LC_MESSAGES/nvda.po 4 0 source/locale/fr/symbols.dic 28 0 user_docs/fr/changes.t2t 3 files changed, 57 insertions(+), 9 deletions(-)
From translation svn revision: 69587 Authors: Simone Dal Maso <[email protected]> Alberto Buffolino <[email protected]> Stats: 20 4 source/locale/it/LC_MESSAGES/nvda.po 35 0 user_docs/it/changes.t2t 2 files changed, 55 insertions(+), 4 deletions(-)
From translation svn revision: 69587 Authors: Takuya Nishimoto <[email protected]> Minako Nonogaki <[email protected]> Stats: 28 0 user_docs/ja/changes.t2t 1 file changed, 28 insertions(+)
From translation svn revision: 69587 Authors: Dan Pungă <[email protected]> Florian Ionașcu <[email protected]> Alexandru Matei <[email protected]> Nicuşor Untilă <[email protected]> Adriani Ionuț Botez <[email protected]> Dragoș Grecianu <[email protected]> Daniela Popovici <[email protected]> George Antonio Andrei <[email protected]> Stats: 220 38 source/locale/ro/LC_MESSAGES/nvda.po 1 file changed, 220 insertions(+), 38 deletions(-)
From translation svn revision: 69587 Authors: Zvonimir Stanecic <[email protected]> Aleksandr Lin'kov <[email protected]> Stats: 30 34 source/locale/ru/LC_MESSAGES/nvda.po 1 file changed, 30 insertions(+), 34 deletions(-)
From translation svn revision: 69587 Authors: Nikola Jovic <[email protected]> Janko Valencik <[email protected]> Zvonimir <[email protected]> Danijela Popovic <[email protected]> Stats: 66 0 user_docs/sr/changes.t2t 52 4 user_docs/sr/userGuide.t2t 2 files changed, 118 insertions(+), 4 deletions(-)
From translation svn revision: 69587 Authors: Cagri Dogan <[email protected]> Stats: 7 1 user_docs/tr/changes.t2t 1 file changed, 7 insertions(+), 1 deletion(-)
From translation svn revision: 69587 Authors: Volodymyr Pyrig <[email protected]> Stats: 94 0 user_docs/uk/changes.t2t 1 file changed, 94 insertions(+)
From translation svn revision: 69587 Authors: Dang Hoai Phuc <[email protected]> Nguyen Van Dung <[email protected]> Stats: 223 35 source/locale/vi/LC_MESSAGES/nvda.po 6 0 user_docs/vi/changes.t2t 2 files changed, 229 insertions(+), 35 deletions(-)
From translation svn revision: 69587 Authors: [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] Stats: 7 0 user_docs/zh_CN/changes.t2t 1 file changed, 7 insertions(+)
From translation svn revision: 69587 Authors: [email protected] [email protected] Aaron Wu <[email protected]> Victor Cai <[email protected]> [email protected] Stats: 26 49 source/locale/zh_TW/LC_MESSAGES/nvda.po 133 0 user_docs/zh_TW/changes.t2t 2 2 user_docs/zh_TW/userGuide.t2t 3 files changed, 161 insertions(+), 51 deletions(-)
From translation svn revision: 69587
Supersedes #14098 Fixes #14094 Summary of the issue: SecureDesktopNVDAObject needs to be whitelisted on the lock screen. This is an NVDAObject used to notify the user and API consumers that NVDA has entered a secure desktop. Description of user facing changes Fixes NVDA remote bug described in #14094. "Secure Desktop" is now consistently announced again when entering a secure desktop. Description of development approach Add SecureDesktopNVDAObject to the whitelist of available objects on the lock screen. Ensures that when setting the foreground event does not occur via doPreGainFocus for SecureDesktopNVDAObject. This is because the foreground event cannot be handled in a secure manner, and is not required for the SecureDesktopNVDAObject API.
Merge rc to beta
feerrenrut
approved these changes
Sep 7, 2022
Collaborator
|
I'm getting the following in the log when entering a secure desktop on alpha: |
6 tasks
seanbudd
added a commit
that referenced
this pull request
Sep 9, 2022
Follow up to #14105 Fixes issue described in #14111 (comment) Summary of the issue: SecureDesktopNVDAObject is an API end point used to indicate to the user and to API consumers (including NVDA remote), that the user has switched to a secure desktop. This is triggered when Windows notification EVENT_SYSTEM_DESKTOPSWITCH notifies that the desktop has changed. The switch is handled via a gainFocus event. The gainFocus event causes the user instance of NVDA to enter sleep mode as the secure mode NVDA instance starts on the secure screen. Information from SecureDesktopNVDAObject should not be accessible to the user, as it is backed by a valid MSAA desktop running on a secure profile, that NVDA can report information from. This should generally be handled by NVDA entering sleep mode. In #14105, SecureDesktopNVDAObject became based on NVDAObject to improve security for the object, by breaking it's connection to a valid window. This was to decrease the theoretical risk of information leakage. However, it was discovered that NVDA core event tracking and API consumers rely on SecureDesktopNVDAObject inheriting from Window (a parent class of Desktop). As such, SecureDesktopNVDAObject must remain a Desktop subclass to retain backwards compatibility. However we can prevent neighbouring objects from being accessed. Description of user facing changes Fixes bug in NVDA alpha with handling SecureDesktopNVDAObject. Fixes API breakage. Description of development approach Reverts the change in #14105, making SecureDesktopNVDAObject inherit from Desktop. Prevents neighbouring objects to SecureDesktopNVDAObject from being accessed by overriding relevant methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Must be a merge commit not a squash merge