Replace outdated comment in Windows Terminal overlay class selection#14048
Merged
seanbudd merged 1 commit intonvaccess:masterfrom Aug 23, 2022
Merged
Conversation
codeofdusk
force-pushed
the
rm-outdated-termcontrol2-comment
branch
from
8b5a596 to
28d2afc
Compare
codeofdusk
force-pushed
the
rm-outdated-termcontrol2-comment
branch
from
28d2afc to
6ef41b6
Compare
See test results for failed build of commit 4c37e40b4b |
seanbudd
approved these changes
Aug 23, 2022
See test results for failed build of commit 89721e2e8f |
See test results for failed build of commit 89721e2e8f |
See test results for failed build of commit 89721e2e8f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
microsoft/terminal#12358
Summary of the issue:
A comment in
NVDAObjects.UIA.FindOverlayClassesdoes not reflect reality.Description of how this pull request fixes the issue:
Comment replaced with a more accurate one.
Testing strategy:
N/A
Known issues with pull request:
None known
Change log entries:
None needed
Code Review Checklist: