Remove UIAHandler.isUIAAvailable, as it is always available#10571
Merged
Conversation
|
PR introduces Flake8 errors 😲 See test results for Failed build of commit 633196bf9a |
Contributor
|
This PR also closes #10300. Thanks @LeonarddeR |
Collaborator
Author
|
Thanks for pointing this out. |
feerrenrut
reviewed
Dec 4, 2019
Co-Authored-By: Reef Turner <[email protected]>
feerrenrut
approved these changes
Dec 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Split from #9968
Fixes #10300
Summary of the issue:
In Windows XP and possibly older versions of Vista, UIA was not always available. Therefore,, the UIAHandler contained logic to deal with UIA not available.
Description of how this pull request fixes the issue:
UIAHandler.isUIAAvailable has been removed, since it was always True, i.e. it depended on the comtypes wrapper being available. We only imported the contents of the comtypes wrapper when UIAHandler.isUIAAvailable was True. Code that used UIAHandler.isUIAAvailable now uses uiaHandler.handler or simply assumes that UIA is always there.
This is a necessary change for #9968, as Sphinx won't run otherwise.
More importantly though, while disabling UIA on ALPHA seemed to fail on my system, it no longer does now.
Testing performed:
Tested running from source, with UIA enabled and disabled from config.
Known issues with pull request:
None
Change log entry: