Add an article role and allow quick navigation to articles#10424
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This was referenced Oct 25, 2019
Collaborator
Author
|
Just did a quick test with the UIA implementation of Edge Chromium. There, it looks like the aria role of article will be properly exposed, even when using the |
michaelDCurran
requested changes
Oct 28, 2019
| readUnit: Optional[str] = None | ||
| ): | ||
| """Adds a script for the given quick nav item. | ||
| @param itemType: The type of item, I.E. "heading" "Link" ... |
Member
There was a problem hiding this comment.
Why was this line removed?
Collaborator
Author
There was a problem hiding this comment.
Ugh, that must have been an accident. Restoring now.
Collaborator
Author
|
In the current implementation, the "out of article" sentence is also spoken when leaving articles. For landmarks, this isn't the case. While landmarks and articles aren't the same, I feel they should behave equivalent in this case. Thus, either they should announce exit, or they shouldn't. See also #10420 |
michaelDCurran
approved these changes
Oct 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #9227
Summary of the issue:
It has been a long standing request to allow quick navigation from/to articles. Also, articles should be able to mentioned as such.
Description of how this pull request fixes the issue:
Testing performed:
Tested the following in Firefox, Chrome and IE:
Known issues with pull request:
The implementation for EdgeHTML is limited in that it works for nodes that have been marked up with the aria role of article. Articles marked up as such with the
<article>tag aren't recognized, because they have the grouping role and the only way to detect whether it's an article is by means of theLocalizedControlType. Bah!Change log entry: