Skip to content

Add lint check for C++ changes #12407

Description

@seanbudd

Is your feature request related to a problem? Please describe.

Unlinted C++ code exists on the master branch of NVDA, and PRs to master can contain unlinted C++ code. Currently reviewers must manually check if a PR introduces unlinted C++ code.

Describe the solution you'd like

It would be nice to have a lint check similar to our flake8 python check that checks if a PR introduces unlinted C++ code.

It would also be good to lint our existing C++ code base, but this may run into problems as discussed on #12261

Potential tool to use: cpplint

Describe alternatives you've considered

Manual checking and linting, other tools

Metadata

Metadata

Assignees

No one assigned

    Labels

    audience/nvda-devPR or issue is relevant to NVDA / Add-on developersp4https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#prioritytriagedHas been triaged, issue is waiting for implementation.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions