Fix neighborhood factors edge case when seq_init=True and cross_view=True #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11
Problem
When both
seq_init=Trueandcross_view=Trueare enabled, the filtering condition becomes mathematically impossible to satisfy:seq_init=Truesetsr=1cross_view=Truesetsc=1abs(ii-jj) > 1 AND abs(ii-jj) <= 1is impossibleThis results in zero edges being added to the factor graph, causing initialization to fail.
Solution
Changed
c = 1 if self.cross_view else 0toc = -1 if self.cross_view else 0This allows:
ii == jj)rTesting
Credit
Thanks to @heiwang1997 for the elegant solution suggestion!