Skip to content

fix: try resolving tailwindcss from module #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ineshbose merged 1 commit into from
Apr 3, 2025
Merged

fix: try resolving tailwindcss from module #974

ineshbose merged 1 commit into from
Apr 3, 2025
+1 −1

Conversation

@danielroe
Copy link
Contributor

@danielroe danielroe commented Apr 3, 2025

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

noticed this issue when multiple versions of tailwindcss were present in a monorepo. It's probably safest to resolve tailwind from the module itself given that it's a dependency of it (and pinned to ~3.4)

@what-the-diff
Copy link

what-the-diff bot commented Apr 3, 2025

PR Summary

  • Improved Module Resolution
    The function responsible for finding a specific module in our codebase (such as our styling system, Tailwind CSS) has been updated to be more efficient. By adding a new parameter (import.meta.url), the system can now identify and locate these modules more accurately, ensuring our styling plan is applied consistently and as intended.
    This could lead to quicker load times and better performance of the website or app.

@netlify
Copy link

netlify bot commented Apr 3, 2025 •
edited
Loading

✅ Deploy Preview for nuxt-tailwindcss ready!

Name Link
🔨 Latest commit 5a58a6e
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-tailwindcss/deploys/67eeb1aa573f390008ab3ff3
😎 Deploy Preview https://deploy-preview-974--nuxt-tailwindcss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ineshbose
ineshbose approved these changes Apr 3, 2025
View reviewed changes
Copy link
Collaborator

@ineshbose ineshbose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ❤️

@ineshbose ineshbose merged commit f767243 into main Apr 3, 2025
7 checks passed
@ineshbose ineshbose deleted the fix/resolution branch April 3, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ineshbose ineshbose ineshbose approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danielroe @ineshbose