Skip to content

Conversation

@marr
Copy link
Contributor

@marr marr commented Mar 7, 2025

πŸ”— Linked issue

closes #960

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Fixes tailwindcss config for nuxt 3.16

@netlify
Copy link

netlify bot commented Mar 7, 2025

πŸ‘· Deploy request for nuxt-tailwindcss pending review.

Visit the deploys page to approve it

Name Link
πŸ”¨ Latest commit 9121997

@what-the-diff
Copy link

what-the-diff bot commented Mar 7, 2025

PR Summary

  • Updated Dependencies
    The versions of several packages listed in the package.json file have been updated. This includes essential packages such as c12, consola, h3, postcss, eslint, and nuxt, among several others. The new versions often include improvements, bug fixes, and security updates that can make our application more robust and efficient. A new package, @nuxt/kit has also been introduced in this version.

  • Code Formatting Enhancement in Playground Configuration
    The code formatting in the playground/nuxt.config.ts has been improved, particularly for a logging statement in the tailwindcss:resolvedConfig hook. It has been rearranged over multiple lines to make it much easier to read and understand.

  • Modifications to Context Loading Logic
    In the src/internal-context/load.ts file, the way our internal context loads has been adjusted. A directory path for pages/**/*${sfcExtensions} has been added to the content.files array. This will better incorporate our page components. It represents an improvement in the way our system handles and loads the various components that make up our pages.

@ineshbose
Copy link
Collaborator

@marr I've raised a PR to your fork (as I didn't have permission to push). Feel free to review and merge, then we can merge this PR πŸ™‚

chore: use hook to watch pages
@ineshbose ineshbose merged commit f226a64 into nuxt-modules:main Mar 10, 2025
3 checks passed
"test:types": "pnpm dev:prepare && tsc --noEmit && nuxi typecheck playground"
},
"dependencies": {
"@nuxt/kit": "^3.15.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ineshbose / @marr Moving this from a dependency to a dev dependency broke the package for us in: https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com/-/merge_requests/4338 because nuxt@2 doesn't seem to ship @nuxt/kit per default.

It probably should be a peer dependency at least

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nuxt/kit should be an explicit dependency - I did not spot that this PR moved it.

unrelatedly, do you need any help migrating https://gitlab.com/gitlab-org/gitlab-services/design.gitlab.com to nuxt 3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Styling breaks after upgrading to nuxt 3.16

4 participants