Skip to content

fix: better check for unsafe config to fallback #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ineshbose merged 5 commits into from
Apr 28, 2024
Merged

fix: better check for unsafe config to fallback #839

ineshbose merged 5 commits into from
Apr 28, 2024

Conversation

@ineshbose
Copy link
Collaborator

@ineshbose ineshbose commented Apr 24, 2024 •
edited
Loading

  • Fix types (enhancements later) and provide more checking to moduleOptions.config
  • Check unsafe props from hooks and go to fallback
  • See if loading config can be moved out of context.ts

Planned for 6.12.1. Will close #838

@netlify
Copy link

netlify bot commented Apr 24, 2024 •
edited
Loading

✅ Deploy Preview for nuxt-tailwindcss ready!

Name Link
🔨 Latest commit 118b17f
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-tailwindcss/deploys/662d1e98400af40008967dcb
😎 Deploy Preview https://deploy-preview-839--nuxt-tailwindcss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@what-the-diff
Copy link

what-the-diff bot commented Apr 24, 2024

PR Summary

  • Update to playground/nuxt.config.ts file
    Removed certain unnecessary resources hence increasing efficiency.
  • Overhaul of src/context.ts file
    Significant changes made for better tracking of changes and enhancing overall security.
  • Modified src/module.ts file
    Introduction of new features and improving older ones to enhance overall functionality. Added necessary warnings for better user experience.
  • Changes in src/types.ts file
    Enhancements made to increase the range of modifiable properties, lending more customizability to the users.

@ineshbose ineshbose changed the title chore: check for more options in config fix: better check for unsafe config to fallback Apr 24, 2024
@ineshbose ineshbose marked this pull request as ready for review April 27, 2024 15:52
@ineshbose ineshbose merged commit 9d78a9f into main Apr 28, 2024
@ineshbose ineshbose deleted the chore/safer-config-checking branch April 28, 2024 09:06
@eoskl eoskl mentioned this pull request Aug 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Safelist causing build failures

2 participants

@ineshbose