Skip to content

feat: first class hmr #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ineshbose merged 34 commits into from
Apr 12, 2024
Merged

feat: first class hmr #818

ineshbose merged 34 commits into from
Apr 12, 2024

Conversation

@ineshbose
Copy link
Collaborator

@ineshbose ineshbose commented Feb 28, 2024 •
edited
Loading

ineshbose and others added 15 commits January 20, 2024 16:08
@nuxt-studio
Copy link

nuxt-studio bot commented Feb 28, 2024

✅ Live Preview ready!

Name Edit Preview Latest Commit
TailwindCSS Edit on Studio ↗︎ View Live Preview 2c0d664

ineshbose
ineshbose commented Feb 28, 2024
View reviewed changes
@ineshbose
Copy link
Collaborator Author

ineshbose commented Mar 24, 2024

Expose config templates may not change.. need to look into that

@ineshbose
Copy link
Collaborator Author

ineshbose commented Mar 24, 2024

tailwindcss:resolvedConfig hook is broken now 🔪😃👍

@ineshbose
Copy link
Collaborator Author

ineshbose commented Mar 24, 2024

need to consider using unctx or something now

ineshbose
ineshbose commented Mar 25, 2024
View reviewed changes
ineshbose
ineshbose commented Mar 25, 2024
View reviewed changes
ineshbose
ineshbose commented Mar 25, 2024
View reviewed changes
ineshbose
ineshbose commented Mar 25, 2024
View reviewed changes
ineshbose
ineshbose commented Mar 25, 2024
View reviewed changes
ineshbose
ineshbose commented Mar 25, 2024
View reviewed changes
@netlify
Copy link

netlify bot commented Mar 27, 2024 •
edited
Loading

✅ Deploy Preview for nuxt-tailwindcss ready!

Name Link
🔨 Latest commit 47f3be4
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-tailwindcss/deploys/661991c67f51e700082ee793
😎 Deploy Preview https://deploy-preview-818--nuxt-tailwindcss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ineshbose ineshbose mentioned this pull request Mar 27, 2024
Closed
@ineshbose
Copy link
Collaborator Author

ineshbose commented Mar 29, 2024

on fresh setup without prepare, some styling is flashing and I may not be too happy with how objects are copied while needing to be passed in configMerger (there's lot of complexity here as well..)

@ineshbose ineshbose mentioned this pull request Apr 6, 2024
Merged
@ineshbose ineshbose mentioned this pull request Apr 11, 2024
Closed
@ineshbose
Copy link
Collaborator Author

ineshbose commented Apr 11, 2024

Just build now not detecting added templates...

@ineshbose
Copy link
Collaborator Author

ineshbose commented Apr 12, 2024

I've been in half minds around writing tests.. may write them or release soon

@ineshbose ineshbose merged commit 81595fe into main Apr 12, 2024
@ineshbose
Copy link
Collaborator Author

ineshbose commented Apr 13, 2024

minor improvement if needed in future - do findPath within loadConfig and also listen for 'add' event from builder in that case. Templates are already triggering due to templatesGenerated hook 👍

@ineshbose ineshbose deleted the first-class-hmr branch April 17, 2024 17:23
@eoskl eoskl mentioned this pull request Aug 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

call tailwindcss:config hook after all modules are initialised HMR for config imports and latency improvement

2 participants

@ineshbose