feat: added fetch requester for ssr reasons#194
Merged
Baroshem merged 1 commit intonuxt-modules:mainfrom Apr 8, 2024
Merged
Conversation
Collaborator
|
Hey @Rigo-m Thanks for this PR! I will review it shortly and release it at the end of the week as I am currently off for short holidays |
Baroshem
approved these changes
Apr 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes atoms-studio/nuxt-swiftsearch#1
Types of changes
Description
useAlgoliaRef exports the esm/browser version of the algoliasearch client.
The browser version uses the browserXHRRequester, which doesn't work in node environments, while the non-esm package works both in client and in server environments because it automatically switches XMLHttpRequester and browserXHRRequester depending on the environment it's called within, and that's why algoliaclient works but useAlgoliaRef does not when passing it to swiftsearch.
Proposed fix is to ubiquitously use the fetch requester, which is a better "futuristic" (more contemporary) approach.
If this works for you I'm going to implement swiftsearch integration after.