Skip to content

chore: test bundler module resolution#189

Merged
Baroshem merged 1 commit intomainfrom
bundler-resolution
Jan 15, 2024
Merged

chore: test bundler module resolution#189
Baroshem merged 1 commit intomainfrom
bundler-resolution

Conversation

@danielroe
Copy link
Copy Markdown
Contributor

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This is a 'canary' pull request. It aims to ensure that the ecosystem is ready for a shift in the default Nuxt TypeScript module resolution from 'Legacy' to 'Bundler': nuxt/nuxt#24837.

'Bundler' module resolution is recommended by Vue and by Vite, but unfortunately there are still many packages that do not have the correct entries in their package.json.

This might include this module or packages that are used by this module. You can see, for example: https://arethetypeswrong.github.io/?p=@nuxtjs/algolia. The initial red X for node10 needs to be fixed in https://github.com/nuxt/module-builder; you can ignore that for now.

If there are any errors reported in CI for this PR, it would be good to fix them for the sake of any users of this module who enable the Bundler module resolution. Feel free to ping me or others on the Nuxt Discord if you need any help resolving - and feel free to check out nuxt/nuxt#24837 for any feedback or comments from others affected.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@danielroe danielroe marked this pull request as ready for review December 21, 2023 12:59
@Baroshem Baroshem merged commit 1b8f33a into main Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants