Added optional key to useAlgoliaRecommend#159
Merged
Baroshem merged 4 commits intonuxt-modules:mainfrom Aug 3, 2023
Merged
Conversation
✅ Live Preview ready!
|
LoMonacoSalvatore
changed the title
Baroshem
reviewed
Aug 2, 2023
Collaborator
Baroshem
left a comment
Baroshem
left a comment
There was a problem hiding this comment.
On recommendation for better Developer Experience IMO :)
Collaborator
|
Thank you so much for this PR. I have added a small recommendation to your code that could make the DX a bit better :) |
Co-authored-by: Jakub Andrzejewski <[email protected]>
Contributor
Author
|
@Baroshem looks way better! Thank you for your change! |
Contributor
|
@Baroshem This is a very useful fix, I'm experiencing the same problem with algolia in my project and I think that this will solve it! |
Collaborator
|
Hey folks, Sorry I had an emergency yesterday. I am merging the code and will release it with the next version soon :) |
Collaborator
|
Release with 1.9.0 version :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Multiple useAlgoliaRecommend calls would overwrite the 'recommend-result' useState. Added an optional key param to make it unique composable
Checklist: