fix(db): use libsql in dev mode when cloudflare preset is set#775
fix(db): use libsql in dev mode when cloudflare preset is set#775atinux merged 1 commit intonuxt-hub:mainfrom
Conversation
|
@onmax is attempting to deploy a commit to the NuxtLabs Team on Vercel. A member of the Team first needs to authorize it. |
3a96918 to
7cd6cac
Compare
commit: |
a05e344 to
cfe6f29
Compare
RihanArfan
left a comment
There was a problem hiding this comment.
Thanks for the PR! 💚 I'm checking with the Drizzle team to see if we can support D1 via binding with startStudioSQLiteServer(). Hopefully this means we can continue to support D1 during dev so the DB matches prod. Launching would be the same as how we do PGlite. If not then we can switch the default sqlite db type to always be libsql during dev.
src/db/runtime/api/studio.get.dev.ts
Outdated
There was a problem hiding this comment.
We shouldn't need to reverse proxy local.dizzle.studio. Nuxt DevTools v3.11 or newer allows passing permissions to the iframe. I've made commit 4f11aae which adds it to v0.10 embed. The browser should then prompt for a permission to access the local network after launching.
There was a problem hiding this comment.
Even though I still cannot make it work in Arc :(
src/db/runtime/api/studio.get.dev.ts
Outdated
There was a problem hiding this comment.
Even though I still cannot make it work in Arc :(
|
Could you please resolve the conflicts @onmax ? |
cfe6f29 to
47c26ef
Compare
47c26ef to
3bf14de
Compare
|
conflicts resolved |
Closes #772
Summary
When
NITRO_PRESET=cloudflare-pagesis set, D1 driver was selected in dev mode causing DevTools Database panel to fail. Fix uses libsql driver in dev mode (D1 only for production).StackBlitz
CLI Reproduction
Verify fix
The
-fixedfolder uses pnpm patch to apply the fix locally.