Import firebase type declarations from firebase/compat#605
Merged
lupas merged 1 commit intonuxt-community:masterfrom Dec 2, 2021
Merged
Import firebase type declarations from firebase/compat#605lupas merged 1 commit intonuxt-community:masterfrom
lupas merged 1 commit intonuxt-community:masterfrom
Conversation
aseidma
force-pushed
the
fix-types
branch
2 times, most recently
from
a8d13ef to
f41c018
Compare
Member
|
Thanks a lot, appreciate it! Published the fix with v8.1.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type declarations are broken as types can not be inferred when working with firebase v9.
I've adjusted
index.d.tsto import the types fromfirebase/compatinstead of justfirebase(deprecated).This restores type inference when working with the module.
Fixes #601