This repository was archived by the owner on Jan 4, 2023. It is now read-only.
fix!: enabled SSR by default and opt-out experimental state#200
Merged
pi0 merged 1 commit intofeat/vite-ssrfrom Sep 30, 2021
Merged
fix!: enabled SSR by default and opt-out experimental state#200pi0 merged 1 commit intofeat/vite-ssrfrom
pi0 merged 1 commit intofeat/vite-ssrfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #200 +/- ##
==========================================
+ Coverage 76.92% 78.88% +1.96%
==========================================
Files 12 12
Lines 260 251 -9
Branches 57 52 -5
==========================================
- Hits 200 198 -2
+ Misses 60 53 -7
Continue to review full report at Codecov.
|
Member
|
Hi @antfu. Actually, the module itself (with client-build) is getting more stable to be used in all nuxt2 projects but SSR implementation is still unstable and hacky:
Also supporting SPA mode with disabled ssr (#185) should be anyway done as is a nuxt feature regardless of what default we use and #189 is probably not the best workaround :) I hope this makes sense and we can merge this change when issues above are solved :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved #185, Close #189
The problem of #185 is caused by the check ignores the check for
ssr: falseand will also disable the server for client build.So I guess maybe we could take the chance to respect the
ssr: falseoption in the top-level nuxt config. Giving the SSR has been improved quite a lot since the previous releases, plus this package itself is marked experimental anyway. I'd feel the SSR support is kinda good enough to not be the "experimental-in-experimental" thing. Which this change, this PR makes the behavior less confusing and a bit more robust.