feat(RadioGroup): configurable label size #881
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| emits: ['update:modelValue', 'change'], | ||
| setup (props, { emit }) { | ||
| const { ui, attrs } = useUI('radioGroup', toRef(props, 'ui'), config, toRef(props, 'class')) | ||
| const { ui: radioUI } = useUI('radio', toRef(props, 'uiRadio'), configRadio) |
There was a problem hiding this comment.
I'd rather call it uiRadio to keep consistency with SelectMenu and others: https://github.com/nuxt/ui/blob/dev/src/runtime/components/forms/SelectMenu.vue#L319
There was a problem hiding this comment.
Not sure why I didn't change that to match the prop 😅
benjamincanac
left a comment
benjamincanac
left a comment
There was a problem hiding this comment.
Shouldn't you remove the hard-coded text-sm? https://github.com/nuxt/ui/blob/dev/src/runtime/components/forms/Radio.vue#L17
|
I thought that too, but removing it caused other alignment issues With the Without the I can spend more time figuring out why that is the happening if you want |
|
Well never mind I figured it out. Needing to add an |
…ton/nuxt-ui into feat/custom-radio-group-label
|
Let me know when you're done 😊 |
|
All done. Ready to merge in! |
|
Thanks 😊 |
2 participants
🔗 Linked issue
#779
❓ Type of change
📚 Description
Allowing the label, required, and help text size on a Radio component to be configured. This also includes a fix where the RadioGroup component was allowed to be configured in the
app.config.tsfile using theselectkey. Documentation updated to include callout about using the newuiRadioprop to configure the Radio options when using theRadioGroupcomponent.Resolves #779
📝 Checklist