Skip to content

feat(locale): add Slovenian language #4140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benjamincanac merged 5 commits into from
May 13, 2025
Merged

feat(locale): add Slovenian language #4140

benjamincanac merged 5 commits into from
May 13, 2025

Conversation

@kacijan
Copy link
Contributor

@kacijan kacijan commented May 12, 2025

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Introduced Slovene translations and updates the SupportedLanguages components languageToCountry mapping with the necessary record.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

benjamincanac
benjamincanac reviewed May 12, 2025
View reviewed changes
@pkg-pr-new
Copy link

pkg-pr-new bot commented May 12, 2025 •
edited
Loading 

npm i https://pkg.pr.new/@nuxt/ui@4140

commit: 002d8f1

benjamincanac
benjamincanac requested changes May 13, 2025
View reviewed changes
Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing the export in src/runtime/locale/index.ts.

@kacijan
Copy link
Contributor Author

kacijan commented May 13, 2025

Thanks!
Renamed file to sl.ts (as that's actually the language code and si is the country code) and added the export to the index file.

@benjamincanac benjamincanac changed the title feat(locale): add Slovene language feat(locale): add Slovenian language May 13, 2025
@benjamincanac
Copy link
Member

benjamincanac commented May 13, 2025

I've renamed the PR title to Slovenian instead of Slovene to match your comment inside SupportedLanguages.vue, is this correct?

@kacijan
Copy link
Contributor Author

kacijan commented May 13, 2025

Yes, both terms are correct

@benjamincanac benjamincanac merged commit e86dc79 into nuxt:v3 May 13, 2025
6 checks passed
@benjamincanac
Copy link
Member

benjamincanac commented May 13, 2025

Thanks 😊

@kacijan kacijan deleted the feat/sl-language-support branch May 13, 2025 18:01
@benjamincanac benjamincanac added the v3 #1289 label Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees

No one assigned

Labels

v3 #1289

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kacijan @benjamincanac