Skip to content

Conversation

@danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

spotted when testing with nuxt nightly image - we currently hard-code to nuxt/dist which won't match nuxt-nightly/dist.

I've also switched to knitwork to generate the export as it handles escaping paths. there was also a bug where non-default exports weren't being correctly re-exported

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 27, 2025

npm i https://pkg.pr.new/@nuxt/ui@3996

commit: 2148f77

@nuxthub-admin
Copy link
Contributor

nuxthub-admin bot commented Apr 27, 2025

βœ… Deployed ui3

Deployed ui3 2148f77 to preview

πŸ”— fix-image-export.ui-6q2.pages.dev
πŸ“Œ 03273e2d.ui-6q2.pages.dev
πŸ“±
View QR Code QR code linking to deployment URL.

πŸ“‹ View deployment logs

@atinux atinux requested a review from benjamincanac April 28, 2025 08:08
@benjamincanac benjamincanac changed the title fix: support nuxt-nightly fix(module): support nuxt-nightly Apr 28, 2025
@benjamincanac benjamincanac merged commit 6366118 into v3 Apr 28, 2025
7 checks passed
@benjamincanac benjamincanac deleted the fix/image-export branch April 28, 2025 08:43
benjamincanac pushed a commit that referenced this pull request Apr 29, 2025
@benjamincanac benjamincanac added the v3 #1289 label May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v3 #1289

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants