Skip to content

fix(RadioGroup): improve items value field type #3995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benjamincanac merged 8 commits into from
Apr 29, 2025
Merged

fix(RadioGroup): improve items value field type #3995

benjamincanac merged 8 commits into from
Apr 29, 2025

Conversation

@reslear
Copy link
Contributor

@reslear reslear commented Apr 27, 2025

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

fix value type in RadioGroupItem for example number format:

CleanShot 2025-04-27 at 18 44 02@2x

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 27, 2025 •
edited
Loading 

npm i https://pkg.pr.new/@nuxt/ui@3995

commit: 0c9ef5e

sandros94
sandros94 approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@sandros94 sandros94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, Thanks!
I did forget to change that

@benjamincanac benjamincanac changed the title fix(type): RadioGroupValue for items fix(RadioGroup): use RadioGroupValue type in items value field Apr 29, 2025
@benjamincanac benjamincanac changed the title fix(RadioGroup): use RadioGroupValue type in items value field fix(RadioGroup): improve items value field type Apr 29, 2025
@benjamincanac benjamincanac merged commit 195773e into nuxt:v3 Apr 29, 2025
6 checks passed
@benjamincanac benjamincanac added the v3 #1289 label May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sandros94 sandros94 sandros94 approved these changes

@romhml romhml Awaiting requested review from romhml

Assignees

No one assigned

Labels

v3 #1289

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@reslear @sandros94 @benjamincanac @genu @danielroe