fix(Table): improve data reactivity
#3967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uration (for performances optimization capabilities) Restore Nuxt UI v2 behaviour of table: nuxt#3962 nuxt#3377 nuxt#3597 nuxt#3821 NB: typecheck issue was already present before this commit ../ui/src/runtime/components/Table.vue:228:3 - error TS2322: Type 'Ref<UnwrapRefSimple<T>[], T[] | UnwrapRefSimple<T>[]>' is not assignable to type 'MaybeRef<T[]>'. Type 'Ref<UnwrapRefSimple<T>[], T[] | UnwrapRefSimple<T>[]>' is not assignable to type 'Ref<T[], T[]>'. Type 'UnwrapRefSimple<T>[]' is not assignable to type 'T[]'. Type 'UnwrapRefSimple<T>' is not assignable to type 'T'. 'UnwrapRefSimple<T>' is assignable to the constraint of type 'T', but 'T' could be instantiated with a different subtype of constraint 'unknown'. Type 'unknown' is not assignable to type 'T'. 'unknown' is assignable to the constraint of type 'T', but 'T' could be instantiated with a different subtype of constraint 'unknown'.
commit: |
benjamincanac
requested changes
Apr 23, 2025
benjamincanac
changed the title
data reactivity
- remove useless new test - change watchDeep prop to more general watchOptions - integrate documentation directly in table props description
benjamincanac
approved these changes
Apr 24, 2025
Member
|
Thanks @zguig52! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #3962 #3377 #3597 #3821
❓ Type of change
📚 Description
Tables are no more reactive in v3, being based on TanStack Table.
By using an internal ref + watcher that automatically trigger data re-assignation to be detected/updated by TanStack.
Optionally, in case of performances issues, original behaviour can be restored by setting watchDepth prop to false. Depth can also be fine tuned to limit it.
📝 Checklist