fix(Table): pass header colspan to th
#3926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
Member
|
Can't we handle |
Contributor
Author
|
There is a well established tanstack way to work with grouped columns in thead and we just don't pass the attribute to table header. AFAIK, rowspan and colspan in tbody are supposed to be done via cell meta, but documentation there is confusing and I am not sure what is the right way. This fix makes the following column definition work: const columns = [
{
header: 'Asset',
columns: [
{
header: 'Symbol',
accessorKey: 'asset.code'
},
{
header: 'Name',
accessorKey: 'asset.name'
},
]
},
{
header: 'Strategy',
columns: [
{
header: 'PCT',
accessorKey: 'strategy.accountPct',
},
{
header: 'Goal',
accessorKey: 'strategy.goal',
}
]
}
]; |
Member
|
Should we unlink the |
Contributor
Author
|
you are right, it should not be there |
Member
|
You've also marked |
benjamincanac
changed the title
colspan to th
benjamincanac
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Related to #3296
❓ Type of change
📚 Description
Currently it is possible to create multi-level table headers, but colspan is not applied to th elements. This functionality is implemented in tanstack table and relies on it's internal mechanics.
📝 Checklist