fix(components): respect transform-origin in popper content
#3919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
benjamincanac
changed the title
transform-origin in popper content
benjamincanac
requested changes
Apr 17, 2025
Member
benjamincanac
left a comment
benjamincanac
left a comment
There was a problem hiding this comment.
Thanks for the PR! I've updated the select-menu to use defuFn instead of string interpolation. It's perfectly fine to use those variables, I would just change the --reka-popper-* variables for consistency.
Contributor
Author
A lot cleaner! Thank you!
Done for the components that were touched in this PR |
benjamincanac
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
This PR adds the correct
transform-originto all components that use popper under the hood.This allows the scale animation to properly animate from the triggering element (and popper position) and leads to animations that are a lot more connected to the element that is triggering the popper. See these two examples where I exaggerated the scale animation scaling and duration:
CleanShot.2025-04-17.at.09.10.13.mp4
CleanShot.2025-04-17.at.09.09.58.mp4
CleanShot.2025-04-17.at.08.56.31.mp4
CleanShot.2025-04-17.at.08.56.53.mp4
I've opted to use the documented transform origin CSS variables that reka publishes as opposed to the
--popperones, which leads to a slightly suboptimal setup inselect-menu.ts.On the other hand, I see that
selectalready uses the "raw" popper variable for the width, so maybe that is actually something we are okay with doing as well, even if it strictly speaking isn't public API? Happy to change it!📝 Checklist