Skip to content

docs: change favicon color on theme color change #3917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benjamincanac merged 1 commit into from
Apr 16, 2025
Merged

docs: change favicon color on theme color change #3917

benjamincanac merged 1 commit into from
Apr 16, 2025

Conversation

@50rayn
Copy link
Contributor

@50rayn 50rayn commented Apr 16, 2025 •
edited
Loading

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Add functionality of changing the colour of the favicon, depending on selected theme colour.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
2025-04-16.at.17.08.57.mp4

@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 16, 2025 •
edited
Loading 

npm i https://pkg.pr.new/@nuxt/ui@3917

commit: 0828f84

@50rayn 50rayn force-pushed the docs/favicon-color branch 2 times, most recently from 1a9debd to 20207d8 Compare April 16, 2025 14:14
benjamincanac
benjamincanac reviewed Apr 16, 2025
View reviewed changes
Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's awesome! You might need to do the same in the error.vue file.

@50rayn 50rayn force-pushed the docs/favicon-color branch from 20207d8 to f120147 Compare April 16, 2025 14:18
@50rayn
Copy link
Contributor Author

50rayn commented Apr 16, 2025

It's awesome! You might need to do the same in the error.vue file.

Done 💪

@50rayn
docs: change favicon color on theme color change
0828f84 
docs: change favicon color on theme color change

jhgfcd
@50rayn 50rayn force-pushed the docs/favicon-color branch from f120147 to 0828f84 Compare April 16, 2025 14:20
@benjamincanac benjamincanac merged commit 02b6b38 into nuxt:v3 Apr 16, 2025
5 checks passed
@benjamincanac
Copy link
Member

benjamincanac commented Apr 16, 2025

Thanks!! 😊

@50rayn 50rayn deleted the docs/favicon-color branch April 16, 2025 14:58
@benjamincanac benjamincanac added the v3 #1289 label Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees

No one assigned

Labels

v3 #1289

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@50rayn @benjamincanac