Skip to content

docs(color-mode): fix computed setter logic in ColorModeButton.vue example #3903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benjamincanac merged 2 commits into from
Apr 17, 2025
Merged

docs(color-mode): fix computed setter logic in ColorModeButton.vue example #3903

benjamincanac merged 2 commits into from
Apr 17, 2025

Conversation

@LoTwT
Copy link
Contributor

@LoTwT LoTwT commented Apr 15, 2025

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The previous setter logic of isDark doesn't match the click event @click="isDark = !isDark". The writable computed needs a new value.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 15, 2025 •
edited
Loading 

npm i https://pkg.pr.new/@nuxt/ui@3903

commit: 74bcdf6

@benjamincanac benjamincanac added the v3 #1289 label Apr 16, 2025
@benjamincanac
Copy link
Member

benjamincanac commented Apr 17, 2025

Not sure to understand the issue here, what is it you're trying to fix?

@LoTwT
Copy link
Contributor Author

LoTwT commented Apr 17, 2025

The original logic works, but it's not right.

isDark is a writable computed. The @click="isDark = !isDark" is to assign a new value to isDark. So the setter should receive a new value to update related variables.

image

@benjamincanac benjamincanac changed the title docs: fix the setter logic of isDark in ColorModeButton.vue docs(color-mode): fix the setter in ColorModeButton.vue example Apr 17, 2025
@benjamincanac benjamincanac changed the title docs(color-mode): fix the setter in ColorModeButton.vue example docs(color-mode): fix computed setter logic in ColorModeButton.vue example Apr 17, 2025
@benjamincanac
Copy link
Member

benjamincanac commented Apr 17, 2025 •
edited
Loading

Oh yes you're absolutely correct! Would you mind applying the same change in playground/app/app.vue?

benjamincanac
benjamincanac approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😊

@benjamincanac benjamincanac merged commit 8ea99f0 into nuxt:v3 Apr 17, 2025
5 checks passed
@LoTwT LoTwT deleted the docs-color-mode branch April 17, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees

No one assigned

Labels

v3 #1289

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LoTwT @benjamincanac