Skip to content

fix(Avatar): proxy $attrs to default slot #3712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benjamincanac merged 1 commit into from
Mar 28, 2025
Merged

fix(Avatar): proxy $attrs to default slot #3712

benjamincanac merged 1 commit into from
Mar 28, 2025

Conversation

@Lionad-Morotar
Copy link
Contributor

@Lionad-Morotar Lionad-Morotar commented Mar 28, 2025 •
edited by benjamincanac
Loading

🔗 Linked issue

Hello, here's the linking

Fix #3710, fix #3699

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Avatar's default slot should also inherit attrs from outter Primitive Component

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 28, 2025 

npm i https://pkg.pr.new/@nuxt/ui@3712

commit: f0a9a3f

@benjamincanac benjamincanac changed the title fix(Avatar): cant as trigger for popover when using default slot fix(Avatar): proxy $attrs to default slot Mar 28, 2025
@benjamincanac benjamincanac merged commit 88f349d into nuxt:v3 Mar 28, 2025
5 checks passed
@benjamincanac
Copy link
Member

benjamincanac commented Mar 28, 2025

Thanks! 😊

@benjamincanac benjamincanac added the v3 #1289 label Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

Assignees

No one assigned

Labels

v3 #1289

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cant use u-avatar as triggers for u-popover tooltip with avatar without src do not work

2 participants

@Lionad-Morotar @benjamincanac