-
Notifications
You must be signed in to change notification settings - Fork 988
feat(RadioGroup): add card and table variants
#3178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploying ui3 with Β
|
| Latest commit: |
8798fdb
|
| Status: | Β β Β Deploy successful! |
| Preview URL: | https://91e35ff4.ui-6q2.pages.dev |
| Branch Preview URL: | https://feat-radio-card.ui-6q2.pages.dev |
388944d to
ed67a8c
Compare
commit: |
a47c0b8 to
b259f2f
Compare
card and table variant
card and table variantcard and table variants
aa74a4f to
87234cb
Compare
|
Any updates on this one please ? |
|
Really needed please βΊ |
|
@Deeyuude I'll try to get back into it soon! |
|
yeah this would be great |
|
This would be awesome! |
|
@benjamincanac this is ready for review. |
β Deployed ui3
π View deployment logs |
|
Thank you for your great work @romhml just a quick question ! Don't you think that the card variant could have an icon beside the label & description ? Like the image in linked issue i mean |
|
@Deeyuude you'll be able to do something similar using the label slot: <URadioGroup :variant="variant" :items="items">
<template #label="{ item }">
<UIcon :name="item.icon" />
<span>
{{ item.label }}
</span>
</template>
</URadioGroup>I don't know if it is a good idea to add something like this by default since it is not generalizable to all variants. |
Thats a good point! |
|
Great work @romhml ! it looks and feels very nice! |
π Linked issue
Resolves #2932
β Type of change
π Description
Introduces two new
cardandtablevariants on theRadioGroupcomponent.π Checklist