fix(Carousel): add tab-based ARIA roles #1516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamincanac
approved these changes
Mar 14, 2024
benjamincanac
changed the title
Member
|
Thanks! 😊 |
|
is possible to add and autoplay fonctionnality to the carousel ? |
This was referenced Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #1484.
❓ Type of change
📚 Description
According to the W3C ARIA Authoring Practices Guide, specifically the page on the Carousel pattern using tab-based ARIA roles is one of the suggested uses of ARIA. This uses that ARIA pattern for the specific Carousel use-case with indicators (as that is what the APA is talking about when it refers to a "tabbed" carousel).
📝 Checklist