feat: new 'github' image provider #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome 👌. Thanks for the PR |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Fixes #314
❓ Type of change
📚 Description
As mentioned in this comment, GitHub can provide a sized image directly. This means we can bypass IPX. This StackOverflow comment mentions the 'size' parameter, I can't see any use of width/height anywhere.
Since GitHub profile images must be square, we can take the maximum of the width/height and use that as the size parameter. If none is provided, we use GitHub's default of
460.I'm not sure how the avatars on GHES work, but I've kept the baseUrl override in place just incase.