Skip to content

Conversation

@iiio2
Copy link
Contributor

@iiio2 iiio2 commented Dec 6, 2025

If we remove type then vs code infers ...args as any[] instead of any. I think it might be better to give array of any what typescript infers. and i've seen other code in nuxt, ...args type is always given as array for something.

@iiio2 iiio2 requested a review from danielroe as a code owner December 6, 2025 06:39
@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai
Copy link

coderabbitai bot commented Dec 6, 2025

Walkthrough

The pull request updates the type annotation of rest parameters in the callOnce function's signature within the Nuxt composables module. The parameter declaration is modified from ...args: any to ...args: any[], correcting the TypeScript type definition for the rest parameter to explicitly represent an array. No functional logic or behaviour is altered by this change.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating the rest parameter type from any to any[] in the callOnce function signature.
Description check ✅ Passed The pull request description clearly relates to the changeset, explaining the reasoning for changing the type annotation from any to any[] for rest parameters.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 6, 2025

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@33825

@nuxt/nitro-server

npm i https://pkg.pr.new/@nuxt/nitro-server@33825

nuxt

npm i https://pkg.pr.new/nuxt@33825

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@33825

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@33825

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@33825

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@33825

commit: 6c36a9d

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 6, 2025

CodSpeed Performance Report

Merging #33825 will not alter performance

Comparing iiio2:chore/provide-explicit-type (6c36a9d) with main (2a91221)

Summary

✅ 10 untouched

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@danielroe danielroe merged commit 16c5193 into nuxt:main Dec 8, 2025
55 of 59 checks passed
@github-actions github-actions bot mentioned this pull request Dec 3, 2025
@iiio2
Copy link
Contributor Author

iiio2 commented Dec 8, 2025

Thanks @danielroe . 😊

@iiio2 iiio2 deleted the chore/provide-explicit-type branch December 8, 2025 17:00
@github-actions github-actions bot mentioned this pull request Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants