Skip to content

Conversation

@edison1105
Copy link
Contributor

🔗 Linked issue

fix https://github.com/vuejs/ecosystem-ci/actions/runs/19626547623/job/56196425924

📚 Description

patchProp and nodeOps are added in vuejs/core v 3.5.25, which should be excluded in imports

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@edison1105 edison1105 changed the title fix(test): add 'patchProp' and 'nodeOps' to excluded Vue helpers fix(test): add patchProp and nodeOps to excluded Vue helpers Nov 24, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 24, 2025

Walkthrough

The change adds two entries, 'patchProp' and 'nodeOps', to the excludedVueHelpers array in the auto-imports test file. This modifies the set of Vue global helpers that are excluded during the test that validates Vue global registration behaviour.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single test file modified with a straightforward array addition
  • No logic changes or conditional alterations introduced
  • Array expansion is a simple, low-risk configuration adjustment
  • No public API signatures affected

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description is directly related to the changeset, explaining why the two Vue helpers need to be excluded and referencing the issue that prompted the fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly and specifically describes the main change: adding two Vue helpers to the excluded list in the test file.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 24, 2025

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@33754

@nuxt/nitro-server

npm i https://pkg.pr.new/@nuxt/nitro-server@33754

nuxt

npm i https://pkg.pr.new/nuxt@33754

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@33754

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@33754

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@33754

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@33754

commit: 5813c5f

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 24, 2025

CodSpeed Performance Report

Merging #33754 will not alter performance

Comparing edison1105:edison/fix/imports (5813c5f) with main (ffa14fe)

Summary

✅ 10 untouched

@danielroe danielroe changed the title fix(test): add patchProp and nodeOps to excluded Vue helpers test: add patchProp and nodeOps to excluded Vue helpers Nov 24, 2025
@danielroe danielroe merged commit 9194a5a into nuxt:main Nov 24, 2025
55 of 58 checks passed
@github-actions github-actions bot mentioned this pull request Nov 17, 2025
@github-actions github-actions bot mentioned this pull request Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants