Skip to content

ci: update action lint config #33710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danielroe merged 2 commits into from
Nov 14, 2025
Merged

ci: update action lint config #33710

danielroe merged 2 commits into from
Nov 14, 2025
+3 −5

Conversation

@iiio2
Copy link
Contributor

@iiio2 iiio2 commented Nov 14, 2025 •
edited
Loading

actually the PR is merged now. (rhysd/actionlint#551, rhysd/actionlint#531)

@iiio2 iiio2 requested a review from danielroe as a code owner November 14, 2025 17:38
@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Nov 14, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai
Copy link

coderabbitai bot commented Nov 14, 2025 •
edited
Loading

Walkthrough

This pull request updates GitHub Actions configuration in two files. It removes an ignore entry from .github/actionlint.yml that previously excluded .github/workflows/gh-ai-moderator.yml from linting, and it adds a top-level permissions block (models: read) to .github/workflows/gh-ai-moderator.yml. No other changes to workflow steps, control flow, or code are present.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Review .github/actionlint.yml to confirm the ignore removal is intentional and scoped correctly.
  • Review .github/workflows/gh-ai-moderator.yml to verify the top-level permissions: models: read is appropriate and does not conflict with job-level permissions.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title "ci: update action lint config" directly relates to the changes made to .github/actionlint.yml and .github/workflows/gh-ai-moderator.yml, which involve updating actionlint configuration and workflow permissions.
Description check ✅ Passed The description references upstream actionlint PRs that enable the changes in this PR, providing context for why the actionlint ignore block can be removed and permissions can be added.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 448885a and b934b3f.

📒 Files selected for processing (1)
  • .github/actionlint.yml (0 hunks)
💤 Files with no reviewable changes (1)
  • .github/actionlint.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: codeql (javascript-typescript)
  • GitHub Check: build
  • GitHub Check: code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 14, 2025 •
edited
Loading

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@33710

@nuxt/nitro-server

npm i https://pkg.pr.new/@nuxt/nitro-server@33710

nuxt

npm i https://pkg.pr.new/nuxt@33710

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@33710

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@33710

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@33710

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@33710

commit: b934b3f

danielroe
danielroe reviewed Nov 14, 2025
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can entirely delete the config in that case

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 14, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #33710 will not alter performance

Comparing iiio2:ci/update-actionlint-config (b934b3f) with main (ab3dd9a)1

Summary

✅ 10 untouched

Footnotes

  1. No successful run was found on main (a202338) during the generation of this report, so ab3dd9a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@iiio2
Copy link
Contributor Author

iiio2 commented Nov 14, 2025

@danielroe , i've deleted actionlint.yml file.

@iiio2 iiio2 requested a review from danielroe November 14, 2025 17:52
@danielroe danielroe merged commit 5bf66d4 into nuxt:main Nov 14, 2025
56 checks passed
@github-actions github-actions bot mentioned this pull request Nov 14, 2025
Merged
@iiio2
Copy link
Contributor Author

iiio2 commented Nov 15, 2025

Thanks @danielroe . 😊

@iiio2 iiio2 deleted the ci/update-actionlint-config branch November 15, 2025 02:43
danielroe pushed a commit that referenced this pull request Dec 9, 2025
@iiio2 @danielroe
ci: update action lint config (#33710)
27cae30
@github-actions github-actions bot mentioned this pull request Dec 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielroe danielroe danielroe approved these changes

Assignees

No one assigned

Labels

4.x chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iiio2 @danielroe