Skip to content

Conversation

@antfu
Copy link
Member

@antfu antfu commented Nov 6, 2025

vite-node has now moved outside of Vitest: antfu-collective/vite-node#5

This PR is for running the test to verify everything works as-is.

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 6, 2025

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@33663

nuxt

npm i https://pkg.pr.new/nuxt@33663

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@33663

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@33663

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@33663

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@33663

commit: 072b05d

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 6, 2025

CodSpeed Performance Report

Merging #33663 will degrade performances by 10.18%

Comparing feat/vite-node (072b05d) with main (6b6ea5f)

Summary

❌ 1 regression
✅ 9 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
writeTypes in the basic-types fixture 80.3 ms 89.4 ms -10.18%

@danielroe
Copy link
Member

looking good!

@antfu antfu marked this pull request as ready for review November 6, 2025 12:45
@antfu antfu requested a review from danielroe as a code owner November 6, 2025 12:45
@coderabbitai
Copy link

coderabbitai bot commented Nov 6, 2025

Walkthrough

The renovate.json configuration file has been modified to remove "vite-node" from the matchPackageNames array within the vitest group. The other entries for vitest package grouping ("vitest" and the /^@vitest// regex pattern) remain unchanged. This adjustment alters the scope of packages included in the vitest update group within Renovate's dependency management configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify that removing "vite-node" from the vitest group is intentional and aligns with project requirements
  • Confirm no syntax errors in the JSON structure after removal

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'docs: update vite-node' is vague and misleading. The actual change removes vite-node from renovate.json configuration, not documentation updates. Revise the title to accurately reflect the configuration change, such as 'chore: remove vite-node from vitest group in renovate.json' or 'chore: update renovate configuration as vite-node moves outside Vitest'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description explains the context (vite-node moving outside Vitest) and the purpose (verify tests work), which relates to the renovate.json change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/vite-node

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6b6ea5f and 072b05d.

⛔ Files ignored due to path filters (2)
  • packages/vite/package.json is excluded by !**/package.json
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml, !pnpm-lock.yaml
📒 Files selected for processing (1)
  • renovate.json (0 hunks)
💤 Files with no reviewable changes (1)
  • renovate.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@danielroe danielroe merged commit 6b5d771 into main Nov 6, 2025
100 of 101 checks passed
@danielroe danielroe deleted the feat/vite-node branch November 6, 2025 12:59
@github-actions github-actions bot mentioned this pull request Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants